-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PlatformWidgetBuilder. #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This widget abstracts the functionality to detect the platform used by the user. Related to #139.
✅ Test Report | |
Mr-Leshiy
reviewed
Mar 20, 2024
...packages/catalyst_voices_shared/lib/src/platform_widget_builder/platform_widget_builder.dart
Outdated
Show resolved
Hide resolved
Mr-Leshiy
reviewed
Mar 20, 2024
...packages/catalyst_voices_shared/lib/src/platform_widget_builder/platform_widget_builder.dart
Outdated
Show resolved
Hide resolved
minikin
requested changes
Mar 20, 2024
...packages/catalyst_voices_shared/lib/src/platform_widget_builder/platform_widget_builder.dart
Outdated
Show resolved
Hide resolved
...packages/catalyst_voices_shared/lib/src/platform_widget_builder/platform_widget_builder.dart
Outdated
Show resolved
Hide resolved
...packages/catalyst_voices_shared/lib/src/platform_widget_builder/platform_widget_builder.dart
Outdated
Show resolved
Hide resolved
minikin
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This widget abstracts the functionality to detect the platform used by the user. Related to #139.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s)
List the issue numbers related to this pull request.
Description of Changes
The PR adds the
PlatformWidgetBuilder
widget. This widget abstracts the functionality to detect the platform used by the user.