Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utility wallet connector #305

Merged
merged 80 commits into from
Apr 9, 2024
Merged

feat: utility wallet connector #305

merged 80 commits into from
Apr 9, 2024

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Mar 14, 2024

Description

Create a simple react app for a Cardano wallet connector app.

Related Issue(s)

List the issue numbers related to this pull request.

Closes #299

Description of Changes

  • Added signTx to interact with wallet.
  • Added builder fields that support 0, 1, 2, 3, 4, 5, 7, 8, 14, 15. According to this.

Screenshots

Screenshot 2024-04-02 at 20 33 58

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the draft Draft label Mar 14, 2024
@apskhem apskhem self-assigned this Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Report | ${\color{lightgreen}Pass: 32/33}$ | ${\color{red}Fail: 1/33}$ |

@apskhem apskhem marked this pull request as draft March 18, 2024 08:28
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the comment I highlighted.

utilities/wallet-tester/Earthfile Outdated Show resolved Hide resolved
@apskhem apskhem requested a review from stevenj April 3, 2024 09:32
stevenj
stevenj previously approved these changes Apr 3, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in a folder name utilities should be utilities.

Mr-Leshiy
Mr-Leshiy previously approved these changes Apr 4, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin added review me PR is ready for review and removed draft Draft labels Apr 4, 2024
@apskhem apskhem requested a review from minikin April 6, 2024 09:38
@minikin minikin enabled auto-merge (squash) April 9, 2024 07:13
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utilities/wallet-tester/tsconfig.json Show resolved Hide resolved
@minikin minikin merged commit 6e6f950 into main Apr 9, 2024
30 checks passed
@minikin minikin deleted the feat/utils-wallet-connector branch April 9, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Create a prototype tool for testing wallets and hand crafter transactions
5 participants