Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Earthfile flutter integration tests #304

Merged
merged 10 commits into from
Mar 15, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Mar 14, 2024

Description

This PR moves web integration tests from github workflow to earthly. It currently runs only chrome and firefox. Support for edge is already there but for now tests are failing due to a flutter bug We will also need to add support for Safari in the future

Related Issue(s)

List the issue numbers related to this pull request.

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 added the draft Draft label Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Report | ${\color{lightgreen}Pass: 10/10}$ | ${\color{red}Fail: 0/10}$ |

@kukkok3 kukkok3 self-assigned this Mar 14, 2024
@kukkok3 kukkok3 linked an issue Mar 14, 2024 that may be closed by this pull request
@kukkok3 kukkok3 added do not merge yet PR is not ready to be merged yet comment me Request for comments and removed draft Draft labels Mar 15, 2024
@kukkok3 kukkok3 removed do not merge yet PR is not ready to be merged yet comment me Request for comments labels Mar 15, 2024
@kukkok3 kukkok3 marked this pull request as ready for review March 15, 2024 13:08
@kukkok3 kukkok3 requested a review from minikin as a code owner March 15, 2024 13:08
@kukkok3 kukkok3 enabled auto-merge (squash) March 15, 2024 13:08
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kukkok3 , LGTM!

@minikin minikin disabled auto-merge March 15, 2024 13:13
@minikin minikin merged commit 6f137a6 into main Mar 15, 2024
33 checks passed
@minikin minikin deleted the feat/earthfile-flutter-integration-tests branch March 15, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Migrate Flutter Web Integration Tests to Earthly
2 participants