Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add openapi linter #208

Merged
merged 27 commits into from
Feb 7, 2024
Merged

feat: add openapi linter #208

merged 27 commits into from
Feb 7, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 13, 2024 •
edited
Loading

Description

Create an openAPI linter target.

Related Issue(s)

Closes #143

Description of Changes

Related Pull Requests

input-output-hk/catalyst-ci#152

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Jan 13, 2024
@bkioshn bkioshn added the enhancement New feature or request label Jan 13, 2024
@minikin minikin enabled auto-merge (squash) January 14, 2024 20:15
@bkioshn bkioshn marked this pull request as draft January 15, 2024 06:37
auto-merge was automatically disabled January 15, 2024 06:37

Pull request was converted to draft

@bkioshn bkioshn mentioned this pull request Jan 15, 2024
Merged
8 tasks
@bkioshn bkioshn mentioned this pull request Jan 17, 2024
Merged
8 tasks
@bkioshn bkioshn mentioned this pull request Feb 2, 2024
Merged
8 tasks
@bkioshn bkioshn mentioned this pull request Feb 5, 2024
Merged
8 tasks
stevenj
stevenj requested changes Feb 6, 2024
View reviewed changes
catalyst-gateway/.spectral.yml Outdated Show resolved Hide resolved
catalyst-gateway/.spectral.yml Outdated Show resolved Hide resolved
@stevenj stevenj marked this pull request as ready for review February 7, 2024 14:38
@stevenj stevenj self-requested a review February 7, 2024 14:38
stevenj
stevenj previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin enabled auto-merge (squash) February 7, 2024 15:20
@minikin minikin merged commit f136705 into main Feb 7, 2024
22 checks passed
@minikin minikin deleted the feat/openapi-lint branch February 7, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

@stevenj stevenj stevenj left review comments

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@bkioshn bkioshn

Labels
enhancement New feature or request
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add OpenAPI linting to our CI process.
3 participants
@bkioshn @stevenj @minikin