Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Add link(s) component #1492

Merged
merged 16 commits into from
Jan 13, 2025
Merged

feat(cat-voices): Add link(s) component #1492

merged 16 commits into from
Jan 13, 2025

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Jan 9, 2025

Description

Component that allows to add links to my proposal, so that user can point voters to relevant information about his project that goes beyond the scope of my proposal.

Related Issue(s)

Resloves #1415

Description of Changes

Adding new component that accepts text and validate it againts pattern.

Screenshots

Nagranie.z.ekranu.2025-01-13.o.12.34.38.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added draft Draft ux/ui UX/UI related issues labels Jan 9, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@LynxLynxx LynxLynxx requested a review from dtscalac January 10, 2025 11:13
@LynxLynxx LynxLynxx requested a review from dtscalac January 10, 2025 14:55
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@LynxLynxx LynxLynxx requested a review from dtscalac January 10, 2025 15:25
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

dtscalac
dtscalac previously approved these changes Jan 10, 2025
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx LynxLynxx marked this pull request as ready for review January 13, 2025 11:28
@LynxLynxx LynxLynxx added review me PR is ready for review and removed draft Draft labels Jan 13, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 383/386}$ | ${\color{red}Fail: 3/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 383/386}$ | ${\color{red}Fail: 3/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@LynxLynxx LynxLynxx merged commit 5810331 into main Jan 13, 2025
39 of 41 checks passed
@LynxLynxx LynxLynxx deleted the feat/1415-add-link branch January 13, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants