Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cat-gateway): Add integration test to IndexDB #1431

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(cat-gateway): Add integration test to IndexDB #1431

wants to merge 1 commit into from
+57 −4

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Dec 23, 2024

Description

Added integration test to test validity of Scylla (IndexDB) queries.

Related Issue(s)

Closes #1318

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem
test(cat-gateway): Setup Scylla testing environment (#1406)
e22210e 
* feat: docker compose file for testing scylla

* feat: docker compose for pg

* feat: earthly test target for scylla

* feat: comment out on scylla

* feat: test module

* feat: tmp testing

* chore: test cfg

* refactor: restructure

* fix: cue typo

* fix: test

* chore: tmp

* chore: public

* chore: bump cardano-chain-follower

* feat: final setup

* chore: remove test cfg

* chore: scylla function

* chore: fix cspell
@apskhem apskhem self-assigned this Dec 23, 2024
@apskhem apskhem linked an issue Dec 23, 2024 that may be closed by this pull request
🛠️ [TASK] : Add integration test to cat-gateway EventDB operations #1318
Open
5 tasks
@apskhem apskhem marked this pull request as draft December 23, 2024 14:20
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@apskhem apskhem added the draft Draft label Dec 23, 2024
@kukkok3 kukkok3 self-requested a review December 24, 2024 08:49
kukkok3
kukkok3 reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls move the test-scylla and test-postgres target in the Earthfile in catalyst-gateway/tests so we dont clogh up the catalyst-gateway earthfile with other targets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 left review comments

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@minikin minikin Awaiting requested review from minikin

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn will be requested when the pull request is marked ready for review bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach will be requested when the pull request is marked ready for review stanislav-tkach is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@apskhem apskhem

Labels
draft Draft
Projects
Catalyst
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add integration test to cat-gateway EventDB operations
2 participants
@apskhem @kukkok3