Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cat-voices): integration tests cleanup #1428

Merged
merged 3 commits into from
Dec 23, 2024
Merged

test(cat-voices): integration tests cleanup #1428

merged 3 commits into from
Dec 23, 2024

Conversation

oldGreg5
Copy link
Contributor

Description

Tidy up

Related Issue(s)

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@oldGreg5 oldGreg5 requested a review from minikin as a code owner December 23, 2024 10:48
@oldGreg5 oldGreg5 requested review from emiride and kukkok3 December 23, 2024 10:48
@oldGreg5 oldGreg5 self-assigned this Dec 23, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@oldGreg5 oldGreg5 enabled auto-merge (squash) December 23, 2024 11:26
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oldGreg5 oldGreg5 merged commit 71cb106 into main Dec 23, 2024
40 checks passed
@oldGreg5 oldGreg5 deleted the tests_refactor branch December 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants