Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): adds deployment #1422

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat(cat-gateway): adds deployment #1422

wants to merge 8 commits into from

Conversation

jmgilman
Copy link
Collaborator

No description provided.

@jmgilman jmgilman changed the title feat(gateway): adds deployment feat(cat-gateway): adds deployment Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

cong-or
cong-or reviewed Dec 19, 2024
View reviewed changes
catalyst-gateway/Earthfile
WORKDIR /app
RUN apt-get update && apt-get install -y curl python3 python3-pip
RUN pip3 install --break-system-packages cqlsh
RUN curl https://certs.secureserver.net/repository/sf-class2-root.crt -o /tmp/keyspaces.crt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this cert anymore?

Copy link
Contributor

@benbooth493 benbooth493 Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. We can remove that and clean up the volumes and mounts associated with it.
Yes we can ditch :91

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@cong-or
feat(replication factor): env var
2069116 
defaults to 1, prod should be 3.
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@minikin minikin added dart Pull requests that update Dart code draft Draft and removed dart Pull requests that update Dart code labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cong-or cong-or cong-or left review comments

@benbooth493 benbooth493 benbooth493 left review comments

@stevenj stevenj Awaiting requested review from stevenj stevenj will be requested when the pull request is marked ready for review stevenj is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy will be requested when the pull request is marked ready for review Mr-Leshiy is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku will be requested when the pull request is marked ready for review saibatizoku is a code owner

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn will be requested when the pull request is marked ready for review bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach will be requested when the pull request is marked ready for review stanislav-tkach is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jmgilman jmgilman

Labels
draft Draft
Projects
Catalyst
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmgilman @benbooth493 @cong-or @minikin