Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): Signed docs insert query #1389

Merged
merged 8 commits into from
Dec 13, 2024
Merged

feat(cat-gateway): Signed docs insert query #1389

merged 8 commits into from
Dec 13, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 13, 2024 •
edited
Loading

Description

  • Added an insert query into the cat-gateway event-db module
  • Added rust integration test for it

Related Issue(s)

Closes #1375, part of #1324

@Mr-Leshiy Mr-Leshiy self-assigned this Dec 13, 2024
@Mr-Leshiy Mr-Leshiy added the draft Draft label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

stevenj
stevenj requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny suggestions otherwise LGTM

catalyst-gateway/bin/src/db/event/signed_docs/tests/mod.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/db/event/signed_docs/tests/mod.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed draft Draft labels Dec 13, 2024
@Mr-Leshiy Mr-Leshiy requested a review from stevenj December 13, 2024 09:35
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@Mr-Leshiy Mr-Leshiy changed the title feat(cat-gateway): Signed docs upsert query feat(cat-gateway): Signed docs insert query Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@stevenj stevenj merged commit 0615491 into main Dec 13, 2024
42 checks passed
@stevenj stevenj deleted the feat/upsert-signed-docs branch December 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@minikin minikin Awaiting requested review from minikin

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
2 participants
@Mr-Leshiy @stevenj