Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cat-voices): adding NuFi and Yoroi #1385

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Dec 12, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from 5751015 to 63f852b Compare December 12, 2024 13:57
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from 63f852b to 2bd568e Compare December 13, 2024 07:13
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 354/369}$ | ${\color{red}Fail: 1/369}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from 2bd568e to 04701d5 Compare December 16, 2024 13:58
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 354/369}$ | ${\color{red}Fail: 1/369}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from 04701d5 to ed53a5f Compare December 17, 2024 06:00
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 354/369}$ | ${\color{red}Fail: 1/369}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 354/369}$ | ${\color{red}Fail: 1/369}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from b4acdcd to 3d4dba7 Compare December 18, 2024 07:58
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 354/369}$ | ${\color{red}Fail: 1/369}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-3 branch 2 times, most recently from 4ef10d8 to 02af3b9 Compare December 18, 2024 08:15
@emiride emiride force-pushed the 546-playwright-refactoring-3 branch from 02af3b9 to 48e15b2 Compare December 18, 2024 08:22
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@emiride emiride self-assigned this Dec 18, 2024
@emiride emiride marked this pull request as ready for review December 18, 2024 08:56
@emiride emiride requested review from oldGreg5 and kukkok3 December 18, 2024 08:56
@emiride emiride enabled auto-merge (squash) December 18, 2024 13:33
@emiride emiride merged commit 3102a63 into main Dec 18, 2024
40 checks passed
@emiride emiride deleted the 546-playwright-refactoring-3 branch December 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
2 participants