Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): proposal template models #1363

Merged
merged 22 commits into from
Dec 23, 2024
Merged

feat(cat-voices): proposal template models #1363

merged 22 commits into from
Dec 23, 2024

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Dec 9, 2024 •
edited
Loading

Description

Creates models from schema, that front can create UI depending on the data that was in schema JSON

Related Issue(s)

Resolves #1426

Description of Changes

  • creating dtos for schema json
  • creating models for schema json
  • converting dtos into models
  • creating proposal builder class that allows to create a response json that is correct with schema json

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added do not review yet Do not review yet comment me Request for comments dart Pull requests that update Dart code labels Dec 9, 2024
@LynxLynxx LynxLynxx self-assigned this Dec 9, 2024
@LynxLynxx LynxLynxx changed the base branch from main to mve3 December 9, 2024 13:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

❌ Test Report | ${\color{lightgreen}Pass: 370/371}$ | ${\color{red}Fail: 1/371}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 371/371}$ | ${\color{red}Fail: 0/371}$ |

@damian-molinski
Copy link
Contributor

Suggestion. Move all Dto-s into single file for easier reading. Make sure you're sticking with one naming convension Dto or DTO That way your MapUtils can be just a private top-level function

This was referenced Dec 12, 2024
Merged
Merged
@damian-molinski
Copy link
Contributor

i've moved to to repository package in #1391, please have a look at this PR and let's align on single approach for this

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 366/366}$ | ${\color{red}Fail: 0/366}$ |

damian-molinski
damian-molinski reviewed Dec 17, 2024
View reviewed changes
...s/internal/catalyst_voices_models/lib/src/proposal_schema/dtos/proposal_definitions_dto.dart Outdated Show resolved Hide resolved
...s/internal/catalyst_voices_models/lib/src/proposal_schema/dtos/proposal_definitions_dto.dart Outdated Show resolved Hide resolved
...ckages/internal/catalyst_voices_models/lib/src/proposal_schema/dtos/proposal_schema_dto.dart Outdated Show resolved Hide resolved
...s/packages/internal/catalyst_voices_models/lib/src/proposal_schema/proposal_definitions.dart Outdated Show resolved Hide resolved
...s/packages/internal/catalyst_voices_models/lib/src/proposal_schema/proposal_definitions.dart Outdated Show resolved Hide resolved
...voices/packages/internal/catalyst_voices_models/lib/src/proposal_schema/proposal_schema.dart Outdated Show resolved Hide resolved
...voices/packages/internal/catalyst_voices_models/lib/src/proposal_schema/proposal_schema.dart Outdated Show resolved Hide resolved
...voices/packages/internal/catalyst_voices_models/lib/src/proposal_schema/proposal_schema.dart Outdated Show resolved Hide resolved
...ckages/internal/catalyst_voices_models/lib/src/proposal_schema/dtos/proposal_schema_dto.dart Outdated Show resolved Hide resolved
...ckages/internal/catalyst_voices_models/lib/src/proposal_schema/dtos/proposal_schema_dto.dart Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 366/366}$ | ${\color{red}Fail: 0/366}$ |

@LynxLynxx LynxLynxx changed the title feat(cat-voices):proposal template models feat(cat-voices): proposal template models Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

@minikin
Copy link
Collaborator

minikin commented Dec 23, 2024

the implementation is based on #1330

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 369/369}$ | ${\color{red}Fail: 0/369}$ |

dtscalac
dtscalac approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit e9d9eac into mve3 Dec 23, 2024
40 checks passed
@dtscalac dtscalac deleted the feat/proposal-template-models branch December 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski left review comments

@dtscalac dtscalac dtscalac approved these changes

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@LynxLynxx LynxLynxx

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First
4 participants
@LynxLynxx @damian-molinski @minikin @dtscalac