Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): In-page Information Cards #1242

Merged
merged 13 commits into from
Nov 26, 2024
Merged

feat(cat-voices): In-page Information Cards #1242

merged 13 commits into from
Nov 26, 2024

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Nov 20, 2024 •
edited
Loading

Description

As an Admin I want to preview, how certain static cards are displayed before, during and after a campaign, so I can check if everything is setup correctly, even if the campaign isn't published yet.

Related Issue(s)

Resolves #1186

Description of Changes

Adding new widget and model for representing information about the campaign.

Screenshots

Zrzut ekranu 2024-11-20 o 14 43 10 Zrzut ekranu 2024-11-20 o 14 43 04 Zrzut ekranu 2024-11-20 o 14 42 47 Zrzut ekranu 2024-11-20 o 14 42 42 Zrzut ekranu 2024-11-20 o 14 42 06 Zrzut ekranu 2024-11-20 o 14 41 55

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx
feat: add InPageInformationCard widget and campaign information model…
426ce12 
… for displaying campaign details and status updates
@LynxLynxx
feat: update InPageInformationCard to dynamically display button text…
8d5cb28 
… based on campaign stage and add corresponding localization entries
@LynxLynxx LynxLynxx requested a review from minikin as a code owner November 20, 2024 13:10
@LynxLynxx LynxLynxx self-assigned this Nov 20, 2024
@LynxLynxx LynxLynxx changed the base branch from main to mve3 November 20, 2024 13:10
@LynxLynxx LynxLynxx added the ux/ui UX/UI related issues label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 334/335}$ | ${\color{red}Fail: 1/335}$ |

@LynxLynxx LynxLynxx added the review me PR is ready for review label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 334/335}$ | ${\color{red}Fail: 1/335}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 338/339}$ | ${\color{red}Fail: 1/339}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 339/339}$ | ${\color{red}Fail: 0/339}$ |

damian-molinski
damian-molinski reviewed Nov 25, 2024
View reviewed changes
catalyst_voices/apps/voices/lib/widgets/cards/in_page_information_card.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/widgets/cards/in_page_information_card.dart Outdated Show resolved Hide resolved
...ices/packages/internal/catalyst_voices_view_models/lib/src/proposal/in_page_information.dart Show resolved Hide resolved
...ices/packages/internal/catalyst_voices_view_models/lib/src/proposal/in_page_information.dart Outdated Show resolved Hide resolved
...ices/packages/internal/catalyst_voices_view_models/lib/src/proposal/in_page_information.dart Outdated Show resolved Hide resolved
...ices/packages/internal/catalyst_voices_view_models/lib/src/proposal/in_page_information.dart Show resolved Hide resolved
...ices/packages/internal/catalyst_voices_view_models/lib/src/proposal/in_page_information.dart Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 340/342}$ | ${\color{red}Fail: 2/342}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 340/342}$ | ${\color{red}Fail: 2/342}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 343/343}$ | ${\color{red}Fail: 0/343}$ |

@LynxLynxx LynxLynxx merged commit 3ab52df into mve3 Nov 26, 2024
38 checks passed
@LynxLynxx LynxLynxx deleted the feat/1186-information-cards branch November 26, 2024 12:32
LynxLynxx added a commit that referenced this pull request Dec 4, 2024
@LynxLynxx @damian-molinski
feat(cat-voices): In-page Information Cards (#1242)
c44d7fa 
* feat: add InPageInformationCard widget and campaign information model for displaying campaign details and status updates

* feat: update InPageInformationCard to dynamically display button text based on campaign stage and add corresponding localization entries

* fix: add missing line for better formatting in InPageInformationCard widget definition

* fix: spelling

* fix: import intl

* fix: theme in tests

* fix: add campaign date formatting utility and integrate it in information cards

* refactor: improve date formatting utility and integrate localized date handling in information cards

* fix: spelling

* fix: to early check if information is DateTimeMixin

---------

Co-authored-by: Damian Moliński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@dtscalac dtscalac Awaiting requested review from dtscalac

Assignees

@LynxLynxx LynxLynxx

Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First
2 participants
@LynxLynxx @damian-molinski