Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): No proposal state widget #1236

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Conversation

LynxLynxx
Copy link
Contributor

Description

When there are no proposals - no proposal state widget should be displayed

Related Issue(s)

Closes #1182

Description of Changes

Added new widget that should be used when we want to represent a proposal state. It can take title and description parameters. Default values are set to: "No draft proposals yet", and "Discovery space will show draft proposals you can comment on, currently there are no draft proposals."

Screenshots

Zrzut ekranu 2024-11-18 o 16 41 57 Zrzut ekranu 2024-11-18 o 16 50 31

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues labels Nov 18, 2024
@LynxLynxx LynxLynxx self-assigned this Nov 18, 2024
@LynxLynxx LynxLynxx requested a review from minikin as a code owner November 18, 2024 16:00
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at your IDE code formatting config

@LynxLynxx LynxLynxx changed the base branch from mve3 to main November 19, 2024 13:23
@LynxLynxx LynxLynxx changed the base branch from main to mve3 November 19, 2024 13:23
…to NoProposals, add no proposal foreground asset
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 335/335}$ | ${\color{red}Fail: 0/335}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx LynxLynxx merged commit 62540c3 into mve3 Nov 20, 2024
38 checks passed
@LynxLynxx LynxLynxx deleted the feat/1182-no-proposal-state branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants