Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): VoicesModalMenu 1183 #1227

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

damian-molinski
Copy link
Contributor

Description

Adds new modal menu widget

Related Issue(s)

Closes #1183

Demo

voices_modal_menu.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Nov 18, 2024
@damian-molinski damian-molinski self-assigned this Nov 18, 2024
@damian-molinski damian-molinski removed the request for review from minikin November 18, 2024 13:20
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@damian-molinski damian-molinski changed the base branch from main to mve3 November 18, 2024 14:14
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@LynxLynxx LynxLynxx changed the base branch from mve3 to mve1 November 19, 2024 08:30
@LynxLynxx LynxLynxx changed the base branch from mve1 to mve3 November 19, 2024 08:31
Copy link
Contributor

@LynxLynxx LynxLynxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@damian-molinski damian-molinski merged commit f78eff2 into mve3 Nov 19, 2024
35 of 36 checks passed
@damian-molinski damian-molinski deleted the feat/category_menu_1183 branch November 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : In-modal Category menu / section
3 participants