Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): uikit deployment #1226

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(cat-voices): uikit deployment #1226

merged 1 commit into from
Nov 18, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Fixes UIKit deployment:

https://github.com/input-output-hk/catalyst-voices/actions/runs/11891897467

The target hasn't been updated when generated code has been removed from the repository and builds on top of catalyst voices target which doesn't have generated code.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added the review me PR is ready for review label Nov 18, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Nov 18, 2024
@dtscalac dtscalac self-assigned this Nov 18, 2024
@dtscalac dtscalac requested a review from minikin as a code owner November 18, 2024 12:03
@minikin minikin enabled auto-merge (squash) November 18, 2024 12:15
@minikin minikin merged commit 51c128f into main Nov 18, 2024
33 checks passed
@minikin minikin deleted the fix/uikit-deployment branch November 18, 2024 12:17
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants