New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cat-voices): Filter OpenAPI json for Flutter #1187

Merged

minikin merged 22 commits into main from chore/1172_filter-openapi-flutter

Nov 18, 2024

Contributor

LynxLynxx commented Nov 11, 2024 •

edited

Loading

Description

New job in CI to filter OpenAPI to reduce enpoints that Flutter uses in frontend

Related Issue(s)

Resolves #1172

Description of Changes

Created new job called filter-openapi which filters cat-gateway-api.json using filter JSON stored in catalyst_voices_services/openapi-filters.json.

Filtered openAPI json
filtered-openapi.json

Breaking Changes

Adding variable use_filtered_openapi with default value true to code-generator job.

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module


          chore: First version of filter-openapi job

77d6fc7

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: comment out openapi-filters.json copy in Earthfile to avoid co…

b7766dc

…nfusion during build process

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: change node image

14a8659

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: verbose flag for openapi-format

3f0eb41

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: copy openapi-filters

66cdca0

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: change dir of copy openapi-filters

b346746

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: don't delete cat-gateway-api for now

6d471ae

Contributor

github-actions bot commented Nov 11, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          chore: working filtering of openapi json

066522c

Contributor

github-actions bot commented Nov 12, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          fix: default value for using filtered openapi

0e5bcf9

LynxLynxx self-assigned this

LynxLynxx added review me dart labels

LynxLynxx requested review from stevenj, damian-molinski and dtscalac

November 12, 2024 12:31

LynxLynxx marked this pull request as ready for review

November 12, 2024 12:31

LynxLynxx requested a review from minikin as a code owner

November 12, 2024 12:31

Contributor

github-actions bot commented Nov 12, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          fix: new filtered cat gateway openAPI files

dbb6c34

Contributor

github-actions bot commented Nov 12, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |


          Merge branch 'main' into chore/1172_filter-openapi-flutter

2000c98


          Merge branch 'main' into chore/1172_filter-openapi-flutter

1d606fd

Contributor

github-actions bot commented Nov 13, 2024

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |


          Merge branch 'main' into chore/1172_filter-openapi-flutter

46381d8

LynxLynxx requested a review from minikin

November 14, 2024 08:00

Contributor

github-actions bot commented Nov 14, 2024

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

LynxLynxx added 2 commits

November 14, 2024 13:33


          Merge branch 'main' into chore/1172_filter-openapi-flutter

1ff962f


          Merge branch 'chore/1172_filter-openapi-flutter' of github.com:input-…

e0bbc2d

…output-hk/catalyst-voices into chore/1172_filter-openapi-flutter

dtscalac reviewed

View reviewed changes

...catalyst_voices_services/lib/generated/catalyst_gateway/cat_gateway_api.swagger.chopper.dart Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Nov 14, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |


          fix: update .gitignore and Earthfile for better handling of generated…

d01e4b1

… Swagger files

Contributor

github-actions bot commented Nov 14, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

dtscalac reviewed

View reviewed changes

catalyst_voices/Earthfile Outdated Show resolved Hide resolved


          fix: modify Earthfile to use filter_openapi ARG and update .gitignore…

… to include devtools_options.yaml

LynxLynxx requested a review from dtscalac

November 15, 2024 12:20

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |


          Merge branch 'main' into chore/1172_filter-openapi-flutter

ac2be1e

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

dtscalac approved these changes

View reviewed changes

Contributor

dtscalac left a comment

LGTM

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Contributor

github-actions bot commented Nov 15, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Contributor

github-actions bot commented Nov 18, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |


          Merge branch 'main' into chore/1172_filter-openapi-flutter

5694abb

Contributor

github-actions bot commented Nov 18, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |


          Merge branch 'main' into chore/1172_filter-openapi-flutter

244d853

Contributor

github-actions bot commented Nov 18, 2024

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

minikin approved these changes

View reviewed changes

minikin merged commit 31ad353 into main

35 of 36 checks passed

minikin deleted the chore/1172_filter-openapi-flutter branch

November 18, 2024 12:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dtscalac dtscalac approved these changes

minikin minikin approved these changes

stevenj Awaiting requested review from stevenj

damian-molinski Awaiting requested review from damian-molinski damian-molinski is a code owner

Labels