Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cat-voices): refactoring playwright tests #1164

Merged
merged 2 commits into from
Dec 5, 2024
Merged

test(cat-voices): refactoring playwright tests #1164

merged 2 commits into from
Dec 5, 2024

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Nov 7, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from 79e5431 to f001725 Compare November 13, 2024 08:55
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@minikin minikin added the draft Draft label Nov 13, 2024
@emiride emiride force-pushed the 546-playwright-refactoring-2 branch 10 times, most recently from 382a406 to 3d4c618 Compare November 14, 2024 18:19
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch 2 times, most recently from 752ff8c to 7aa9fe5 Compare November 28, 2024 09:06
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from 7aa9fe5 to 9320c25 Compare November 29, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from 9320c25 to dec7ea8 Compare December 2, 2024 11:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch 2 times, most recently from 34196a7 to 77efa85 Compare December 4, 2024 08:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 340/354}$ | ${\color{red}Fail: 0/354}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from 77efa85 to 84868ef Compare December 4, 2024 11:36
@emiride emiride requested a review from oldGreg5 December 4, 2024 11:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from 84868ef to a6194e2 Compare December 4, 2024 12:19
@emiride emiride marked this pull request as ready for review December 4, 2024 12:29
@emiride emiride added review me PR is ready for review and removed draft Draft labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride force-pushed the 546-playwright-refactoring-2 branch from a6194e2 to fc3087e Compare December 4, 2024 16:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@emiride emiride merged commit 5a42e7c into main Dec 5, 2024
37 of 38 checks passed
@emiride emiride deleted the 546-playwright-refactoring-2 branch December 5, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldGreg5 oldGreg5 oldGreg5 approved these changes

@minikin minikin Awaiting requested review from minikin

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@emiride emiride

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First
3 participants
@emiride @oldGreg5 @minikin