Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flutter/catalyst_key_derivation): Key derivation integration #1149

Merged
merged 158 commits into from
Nov 13, 2024
Merged

feat(flutter/catalyst_key_derivation): Key derivation integration #1149

merged 158 commits into from
Nov 13, 2024

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Nov 6, 2024 •
edited
Loading

Description

  • Makes the catalyst_key_derivation unit testable.
  • Integrates key derivation package into Catalyst Voices app.
  • Moves Ed25519 related utils from catalyst_cardano_serialization to catalyst_key_derivation.
  • feat: rust key derivation #1063 must be merged first before this PR.

Related Issue(s)

Closes #1012

Screenshots

Before:

before.mov

After:

after.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

bkioshn and others added 30 commits October 29, 2024 15:05
@bkioshn
feat(cat-voice-package): add rust key derivation implementation
d872480 
Signed-off-by: bkioshn <[email protected]>
@damian-molinski
refactor: move uikit_example into utilities dir
939d4a2
@damian-molinski
fix: exclude example packages from melos bootstrap
e387a27
@damian-molinski
refactor: move poc_local_storage into catalyst_voices/utilities
8847b78
@bkioshn
fix: key derivation implementation
c90d392 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix: auto gen file
9be664a 
Signed-off-by: bkioshn <[email protected]>
@damian-molinski
refactor: move catalyst_voices_remote_widgets package to catalyst_voi…
7960858 
…ces/utilities dir
@damian-molinski
refactor: move scripts into catalyst_voices dir
376cfb3
@damian-molinski
refactor: move catalyst_voices/packages into catalyst_voices/packages…
93c9d24 
…/internal
@damian-molinski
refactor: move catalyst_voices_packages into catalyst_voices/packages…
cdd42d2 
…/external
@damian-molinski
refactor: move melos.yaml into catalyst_voices
9571bc5
@bkioshn
fix: add word to dict
021c13d 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix: key derivation implementation
78eccc9 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
Merge branch 'main' into feat/rust-key-derivation
b971eb8
@bkioshn
fix: remove simple rs
6d58c65 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
Merge branch 'main' into feat/rust-key-derivation
c7a3ab3
@bkioshn
fix: flutter format
31f1237 
Signed-off-by: bkioshn <[email protected]>
@damian-molinski
refactor: move app into apps/voices dir
557748b
@damian-molinski
refactor: rename packages/external to packages/libs
166cf2d
@damian-molinski
docs: update README
f0d301f
@dtscalac
style: dart lint issues
f4dd7b2
@damian-molinski
fix: builder target
e0cde31
@damian-molinski
fix: update paths in Earthfile
665a38c
@damian-molinski
fix: uikit_example pubspec + libs examples deps override
9057dab
@damian-molinski
chore: test
75266d2
@damian-molinski
Merge main into refactor/self-contained-frontend_899
13aef88
@damian-molinski
fix: update cspell and check markdown rules
5bcc56d
@damian-molinski
fix: README formatting
b02550d
@bkioshn
fix: add description to module
e45f1a5 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix: add cspell dict
63ef11f 
Signed-off-by: bkioshn <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

@dtscalac dtscalac added review me PR is ready for review and removed do not review yet Do not review yet labels Nov 13, 2024
@dtscalac dtscalac marked this pull request as ready for review November 13, 2024 09:05
@dtscalac dtscalac requested a review from minikin November 13, 2024 09:05
@dtscalac dtscalac added the dart Pull requests that update Dart code label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

Base automatically changed from feat/rust-key-derivation to main November 13, 2024 11:01
@dtscalac
Merge branch 'main' into feat/dart-key-derivation
937dc1a 
# Conflicts:
#	catalyst_voices/packages/libs/catalyst_key_derivation/Earthfile
#	catalyst_voices/packages/libs/catalyst_key_derivation/README.md
#	catalyst_voices/packages/libs/catalyst_key_derivation/example/lib/main.dart
#	catalyst_voices/packages/libs/catalyst_key_derivation/lib/catalyst_key_derivation.dart
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

damian-molinski
damian-molinski reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac removed the do not merge yet PR is not ready to be merged yet label Nov 13, 2024
@dtscalac dtscalac merged commit 618f769 into main Nov 13, 2024
38 checks passed
@dtscalac dtscalac deleted the feat/dart-key-derivation branch November 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx is a code owner

@minikin minikin Awaiting requested review from minikin

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add cardano hard and soft key derivation
4 participants
@dtscalac @damian-molinski @bkioshn @stevenj