Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cat-voices): fix nightly tests #1142

Merged
merged 1 commit into from
Nov 5, 2024
Merged

test(cat-voices): fix nightly tests #1142

merged 1 commit into from
Nov 5, 2024

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Nov 5, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@emiride emiride self-assigned this Nov 5, 2024
@kukkok3 kukkok3 self-requested a review November 5, 2024 18:19
@emiride emiride added the review me PR is ready for review label Nov 5, 2024
@emiride emiride marked this pull request as ready for review November 5, 2024 18:24
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit 69772c8 into main Nov 5, 2024
63 checks passed
@kukkok3 kukkok3 deleted the 975-fix-nightly-test branch November 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
2 participants