Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cat-voices): 1128 remove openapi #1130

Closed
wants to merge 7 commits into from

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Nov 5, 2024

Description

Remove OpenAPI spec flutter code generation

Related Issue(s)

Resolves #1128

Description of Changes

  • Remove code-generator and test-flutter-code-generator targets from catalyst_voices/Earthfile.
  • Remove dependencies pulled by code-generator and test-flutter-code-generator which are no longer needed (chopper, etc)
  • Remove generated cat_cateway_api files
  • Remove references to code-generator and test-flutter-code-generator across the project (Justfile, README, etc).

Related Pull Requests

Relates to input-output-hk/catalyst-ci#350

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added do not review yet Do not review yet dart Pull requests that update Dart code labels Nov 5, 2024
@LynxLynxx LynxLynxx self-assigned this Nov 5, 2024
@LynxLynxx LynxLynxx added review me PR is ready for review and removed do not review yet Do not review yet labels Nov 5, 2024
@LynxLynxx LynxLynxx marked this pull request as ready for review November 5, 2024 12:02
@LynxLynxx LynxLynxx requested a review from minikin as a code owner November 5, 2024 12:02
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

stevenj
stevenj previously approved these changes Nov 5, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@damian-molinski damian-molinski marked this pull request as draft November 6, 2024 10:54
@minikin minikin added the do not merge yet PR is not ready to be merged yet label Nov 11, 2024
@LynxLynxx LynxLynxx closed this Nov 13, 2024
@LynxLynxx LynxLynxx deleted the refactor/1128-remove-openapi branch November 13, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Remove OpenAPI spec flutter code generation
4 participants