Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cat-gateway): update MultiEraBlock and MultiEraTx to use with WithRawAuxiliary suffix #1043

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Oct 23, 2024

Description

  • Updated cardano-chain-follower to use this branch (PR).
  • Changed the parts that previously used MultiEraTx or MultiEraBlock to have suffix WithRawAuxiliary.

Related Issue(s)

Closes #1037

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Oct 23, 2024
@apskhem apskhem added enhancement New feature or request review me PR is ready for review labels Oct 23, 2024
@apskhem apskhem changed the title refactor(rust/cardano-chain-follower): update MultiEraBlock and MultiEraTx to use with WithRawAuxiliary suffix refactor(cat-gateway): update MultiEraBlock and MultiEraTx to use with WithRawAuxiliary suffix Oct 23, 2024
@apskhem apskhem marked this pull request as draft October 23, 2024 14:04
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@minikin minikin added the draft Draft label Oct 28, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

@stevenj stevenj removed the review me PR is ready for review label Nov 26, 2024
@stevenj
Copy link
Collaborator

stevenj commented Nov 26, 2024

This PR is blocked pending the acceptance and merging of: txpipe/pallas#534

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 331/331}$ | ${\color{red}Fail: 0/331}$ |

@stevenj stevenj added the do not merge yet PR is not ready to be merged yet label Nov 29, 2024
@stevenj stevenj added the do not review yet Do not review yet label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet do not review yet Do not review yet draft Draft enhancement New feature or request
Projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Update Catalyst Chain follower to utilise these new features
4 participants