Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: API cleanup #1036

Merged
merged 66 commits into from
Oct 28, 2024
Merged

fix: API cleanup #1036

merged 66 commits into from
Oct 28, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Oct 22, 2024 •
edited
Loading

Description

Cleanup API

Related Issue(s)

Closes #1029

Description of Changes

Refer to #1029 for all the changes

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft October 22, 2024 05:42
@bkioshn bkioshn added the enhancement New feature or request label Oct 22, 2024
@bkioshn bkioshn self-assigned this Oct 22, 2024
@bkioshn bkioshn added this to the M4: Voting & Delegation milestone Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 309/309}$ | ${\color{red}Fail: 0/309}$ |

@bkioshn bkioshn marked this pull request as ready for review October 22, 2024 13:37
@bkioshn bkioshn added the review me PR is ready for review label Oct 22, 2024
stevenj and others added 24 commits October 26, 2024 18:07
@stevenj
fix(cat-gateway): cleanup error handling, and add a global 429 respon…
f28400f 
…se to all endpoints.
@bkioshn
fix: config endpoint example, desc, and return
1c25ee7 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
chore: remove todo
84e0bbc 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix: move config object
60ed38b 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix: move cip36 object
b6921d0 
Signed-off-by: bkioshn <[email protected]>
@stevenj
docs(cat-gateway): Add missing headers to responses
70c37d4
@stevenj
Merge branch 'fix/api-cleanup' of github.com:input-output-hk/catalyst…
6f4ef3e 
…-voices into fix/api-cleanup
@stevenj
docs(cat-gateway): Cleanup the rest of the documentation in the api
886ce19
@stevenj
fix(cat-gateway): Fix OpenAPI linting and add autogenerated api file …
fe71882 
…for dart.
@stevenj
refactor(cat-gateway): Better generalize the OpenAPI simple string ty…
c64d473 
…pe creation macro.
@stevenj
fix(cat-gateway): Add APIKey and CatToken auth to some endpoints. Add…
1459b7a 
… 401 and 403 common responses.
@stevenj
fix(cat-gateway): Add universal 422 response to all endpoints, and tr…
5a79bb4 
…y and make all endpoint validation use it.
@bkioshn
fix: add cardano stake address type
65063d3 
Signed-off-by: bkioshn <[email protected]>
@bkioshn
fix(cat-gateway): stake address type
4895f9c 
Signed-off-by: bkioshn <[email protected]>
@stevenj
fix(cat-gateway): Refactor the RBAC Token auth, so it's easier to mai…
4caefd4 
…ntain.
@stevenj
Merge branch 'fix/api-cleanup' of github.com:input-output-hk/catalyst…
9adcaa7 
…-voices into fix/api-cleanup
@bkioshn
fix(cat-gateway): stake address name
c8d2e21 
Signed-off-by: bkioshn <[email protected]>
@stevenj
fix(cat-gateway): Add no auth and no-auth+rbac auth schemes
1048c90
@stevenj
Merge branch 'fix/api-cleanup' of github.com:input-output-hk/catalyst…
2caa2c4 
…-voices into fix/api-cleanup
@bkioshn
fix(cat-gateway): format + stake addr example
2e704ea 
Signed-off-by: bkioshn <[email protected]>
@stevenj
fix(cat-gateway): code format
403e3f5
@stevenj
Merge branch 'fix/api-cleanup' of github.com:input-output-hk/catalyst…
a8d9647 
…-voices into fix/api-cleanup
@stevenj
Merge branch 'main' into fix/api-cleanup
1e0db3b
@bkioshn
fix(cat-gateway): openapi spectral example rules
b6482f1 
Signed-off-by: bkioshn <[email protected]>
@stevenj stevenj removed the do not merge yet PR is not ready to be merged yet label Oct 28, 2024
stevenj
stevenj approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 32ef686 into main Oct 28, 2024
36 checks passed
@stevenj stevenj deleted the fix/api-cleanup branch October 28, 2024 14:09
@stevenj stevenj restored the fix/api-cleanup branch October 28, 2024 14:09
@stevenj stevenj mentioned this pull request Nov 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@stevenj stevenj stevenj approved these changes

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@minikin minikin Awaiting requested review from minikin

Assignees

@bkioshn bkioshn

Labels
enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Cleanup API endpoints
3 participants
@bkioshn @stevenj @Mr-Leshiy