Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): escape special characters in arb #1015

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Oct 16, 2024

Description

The special character ' needs to be escaped in arb files by prepending another ' in front of it, otherwise it's interpreted as a start of escaping sequence. Since this would require a lot of attention while adding localizations lets disable escaping but allow relax-syntax which will show special characters as they are if they are not formed properly.

I.e. {name} would be considered a localization with name variable, {name would just simply display as {name.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added bug Something isn't working review me PR is ready for review dart Pull requests that update Dart code labels Oct 16, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 16, 2024
@dtscalac dtscalac self-assigned this Oct 16, 2024
@dtscalac dtscalac requested a review from minikin as a code owner October 16, 2024 18:40
@dtscalac dtscalac removed the request for review from minikin October 16, 2024 18:40
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit a848e87 into main Oct 17, 2024
39 checks passed
@dtscalac dtscalac deleted the fix/arb-escape-quotes branch October 17, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants