Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): vault crypto #1011

Merged
merged 25 commits into from
Oct 17, 2024
Merged

feat(cat-voices): vault crypto #1011

merged 25 commits into from
Oct 17, 2024

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Oct 16, 2024

Description

Adds encryption of all data coming in/out of Vault using VaultCryptoService.

Key derivation

Pbkdf2 key derivation algorithm instead of Argon2id because BrowserCryptography has native browser implementation of it and times are significantly faster (0:00:00.001200 instead of 1.3s!).

Encryption / Decryption

AesGcm with 256 bits is used.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added do not review yet Do not review yet dart Pull requests that update Dart code labels Oct 16, 2024
@damian-molinski damian-molinski self-assigned this Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Report | ${\color{lightgreen}Pass: 288/288}$ | ${\color{red}Fail: 0/288}$ |

@damian-molinski damian-molinski changed the title feat(cat-voices): vault crypto 1001 feat(cat-voices): vault crypto Oct 16, 2024
@damian-molinski damian-molinski removed the do not review yet Do not review yet label Oct 17, 2024
@damian-molinski damian-molinski added the review me PR is ready for review label Oct 17, 2024
@damian-molinski damian-molinski marked this pull request as ready for review October 17, 2024 06:44
@damian-molinski damian-molinski removed the request for review from minikin October 17, 2024 07:16
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit 57c47ce into main Oct 17, 2024
37 checks passed
@damian-molinski damian-molinski deleted the feat/vault_crypto_1001 branch October 17, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants