Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust/rbac-registration): Tracking payment key type #93

Merged
merged 10 commits into from
Dec 2, 2024
Merged

fix(rust/rbac-registration): Tracking payment key type #93

merged 10 commits into from
Dec 2, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 2, 2024 •
edited
Loading

Description

  • Change tracking payment key type to be CIP-19 Shelley Address
  • Remove tracking payment key and use tracking payment history
  • Add test for registration chain new and update

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn changed the base branch from main to feat/rbac-registration December 2, 2024 07:03
@bkioshn bkioshn marked this pull request as draft December 2, 2024 07:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 253/253}$ | ${\color{red}Fail: 0/253}$ |

@bkioshn bkioshn self-assigned this Dec 2, 2024
@bkioshn bkioshn added bug Something isn't working enhancement New feature or request labels Dec 2, 2024
@bkioshn bkioshn marked this pull request as ready for review December 2, 2024 07:41
@bkioshn bkioshn added the review me PR is ready for review label Dec 2, 2024
@bkioshn bkioshn marked this pull request as draft December 2, 2024 10:18
@bkioshn bkioshn marked this pull request as ready for review December 2, 2024 12:04
stevenj
stevenj approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit d60fb50 into feat/rbac-registration Dec 2, 2024
25 checks passed
@stevenj stevenj deleted the fix/rbac-tracking-addr branch December 2, 2024 15:36
stevenj added a commit that referenced this pull request Dec 2, 2024
@bkioshn @stevenj
feat(rust/rbac-registration): RBAC registration (#85)
149bf11 
* feat: move cip509 from cardano chain follower

Signed-off-by: bkioshn <[email protected]>

* fix: remove key ref and use key local ref

Signed-off-by: bkioshn <[email protected]>

* fix: structure of x509, c509, and public key

Signed-off-by: bkioshn <[email protected]>

* fix: validation

Signed-off-by: bkioshn <[email protected]>

* fix: update x509 and c509 certs

Signed-off-by: bkioshn <[email protected]>

* fix: key local ref

* fix: c509 cert

Signed-off-by: bkioshn <[email protected]>

* fix: to string

Signed-off-by: bkioshn <[email protected]>

* fix: rearrange utils

Signed-off-by: bkioshn <[email protected]>

* fix: cargo toml

Signed-off-by: bkioshn <[email protected]>

* fix: add new type + comment

Signed-off-by: bkioshn <[email protected]>

* fix: linter

Signed-off-by: bkioshn <[email protected]>

* fix: smart pointer

Signed-off-by: bkioshn <[email protected]>

* chore: fix format

Signed-off-by: bkioshn <[email protected]>

* fix: cleanup cargo.toml

Signed-off-by: bkioshn <[email protected]>

* fix: add rbac-registration to earthly rust

* fix: move cip509 validation

Signed-off-by: bkioshn <[email protected]>

* fix: rust ci

Signed-off-by: bkioshn <[email protected]>

* feat: add role signing key validation

Signed-off-by: bkioshn <[email protected]>

* fix: add Bytes conversion for Pubkey

Signed-off-by: bkioshn <[email protected]>

* fix: error return

* fix: use Hash from pallas for tx hash

Signed-off-by: bkioshn <[email protected]>

* fix: format

Signed-off-by: bkioshn <[email protected]>

* fix: bytes to pubkey conversion

* fix: add Bytes conversion for Pubkey

Signed-off-by: bkioshn <[email protected]>

* fix: add rbac-reg to semantic pull request

* fix: test data

Signed-off-by: bkioshn <[email protected]>

* fix: signing and encryption key

Signed-off-by: bkioshn <[email protected]>

* fix: format

Signed-off-by: bkioshn <[email protected]>

* fix: witness test data to be compatible with new test data

Signed-off-by: bkioshn <[email protected]>

* fix: validate stake public key witness and add test for role signing key

Signed-off-by: bkioshn <[email protected]>

* chore: doc about context specific

Signed-off-by: bkioshn <[email protected]>

* chore: fix format

Signed-off-by: bkioshn <[email protected]>

* fix: remove test since cip509 decode are done in validation test

* fix: test

* fix: test compression data

Signed-off-by: bkioshn <[email protected]>

* feat(rust/rbac-registration): add cardano registration chain (#90)

* feat: add cardano registration chain

Signed-off-by: bkioshn <[email protected]>

* feat: add wrapper to registration chain inner

Signed-off-by: bkioshn <[email protected]>

* fix: format

Signed-off-by: bkioshn <[email protected]>

* fix: comment

Signed-off-by: bkioshn <[email protected]>

* fix: signing and encryption key

Signed-off-by: bkioshn <[email protected]>

* chore: fix format

Signed-off-by: bkioshn <[email protected]>

* fix: move struct to its own file and private the inner regis

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>

* fix: remove txn index and change test data to chain root

Signed-off-by: bkioshn <[email protected]>

* chore: fix comment

Signed-off-by: bkioshn <[email protected]>

* fix: remove tx index from cip-509 validate function

Signed-off-by: bkioshn <[email protected]>

* fix: test data

Signed-off-by: bkioshn <[email protected]>

* chore: fix format

* fix: remove txn index from validate

Signed-off-by: bkioshn <[email protected]>

* fix: format

* fix(rust/rbac-registration): Tracking payment key type (#93)

* fix: payment key shelley address and add test for registration chain

Signed-off-by: bkioshn <[email protected]>

* chore: comment

* fix: format

* fix: use ShelleyPaymentPart

Signed-off-by: bkioshn <[email protected]>

* fix: track ShelleyAddress

Signed-off-by: bkioshn <[email protected]>

* fix: remove tracking_payment_key and use tracking_payment_history

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

Assignees

@bkioshn bkioshn

Labels
bug Something isn't working enhancement New feature or request review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkioshn @stevenj