Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/rbac-registration): RBAC registration #85

Merged
merged 49 commits into from
Dec 2, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Nov 19, 2024

Description

Create a RBAC registration library

Related Issue(s)

Closes #87

Description of Changes

  • Create a RBAC registration lib
  • Move CIP509 and its validation from cardano-chain-follower

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft November 19, 2024 07:49
@bkioshn bkioshn changed the title Feat/rbac registration feat: RBAC registration Nov 26, 2024
Signed-off-by: bkioshn <[email protected]>
@bkioshn bkioshn changed the title feat: RBAC registration feat(rbac-registration): RBAC registration Nov 26, 2024
@bkioshn bkioshn changed the title feat(rbac-registration): RBAC registration feat(rust/rbac-registration): RBAC registration Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Test Report | ${\color{lightgreen}Pass: 253/253}$ | ${\color{red}Fail: 0/253}$ |

@bkioshn bkioshn added the enhancement New feature or request label Nov 29, 2024
@bkioshn bkioshn marked this pull request as ready for review November 29, 2024 07:55
bkioshn and others added 4 commits November 29, 2024 21:35
* feat: add cardano registration chain

Signed-off-by: bkioshn <[email protected]>

* feat: add wrapper to registration chain inner

Signed-off-by: bkioshn <[email protected]>

* fix: format

Signed-off-by: bkioshn <[email protected]>

* fix: comment

Signed-off-by: bkioshn <[email protected]>

* fix: signing and encryption key

Signed-off-by: bkioshn <[email protected]>

* chore: fix format

Signed-off-by: bkioshn <[email protected]>

* fix: move struct to its own file and private the inner regis

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
@bkioshn bkioshn added the do not merge yet PR is not ready to merge yet label Dec 2, 2024
bkioshn and others added 6 commits December 2, 2024 13:48
Signed-off-by: bkioshn <[email protected]>
* fix: payment key shelley address and add test for registration chain

Signed-off-by: bkioshn <[email protected]>

* chore: comment

* fix: format

* fix: use ShelleyPaymentPart

Signed-off-by: bkioshn <[email protected]>

* fix: track ShelleyAddress

Signed-off-by: bkioshn <[email protected]>

* fix: remove tracking_payment_key and use tracking_payment_history

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 149bf11 into main Dec 2, 2024
24 checks passed
@stevenj stevenj deleted the feat/rbac-registration branch December 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to merge yet enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Extract the RBAC registration out from cardano-chain-follower
2 participants