Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust/vote-tx-v2): Finish GeneralisedTx CBOR decoding functionality #83

Merged
merged 6 commits into from
Nov 15, 2024
Merged

feat(rust/vote-tx-v2): Finish GeneralisedTx CBOR decoding functionality #83

merged 6 commits into from
Nov 15, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Added a final pieces for the GeneralisedTx CBOR decoding functionality.

Related Issue(s)

Closes #75

Description of Changes

  • Added missing signature: coset::CoseSign field with decoding implementation.
  • Added missing event: EventMap field and underlying structs with decoding implementation.

@Mr-Leshiy Mr-Leshiy self-assigned this Nov 15, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 217/217}$ | ${\color{red}Fail: 0/217}$ |

cong-or
cong-or approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy merged commit d4dc27a into main Nov 15, 2024
24 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/vote-tx-v2 branch November 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cong-or cong-or cong-or approved these changes

@saibatizoku saibatizoku Awaiting requested review from saibatizoku

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Generalizes voting tx decoding implementation
2 participants
@Mr-Leshiy @cong-or