Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust/cbork): Add a CDDL preprocessing step #80

Merged
merged 17 commits into from
Nov 26, 2024
Merged

feat(rust/cbork): Add a CDDL preprocessing step #80

merged 17 commits into from
Nov 26, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Nov 10, 2024 •
edited
Loading

Description

  • Slightly refactored cbork-cddl-parser implementation
  • Added a new preprocessing step (process_ast function)
  • Refactored integration tests, moved CDDLTestParser under the tests/common.rs mod.

@Mr-Leshiy Mr-Leshiy self-assigned this Nov 10, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat(rust/cbork-cddl-parser): Add a CDDL preprocessing step feat(rust/cbork): Add a CDDL preprocessing step Nov 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 217/217}$ | ${\color{red}Fail: 0/217}$ |

@Mr-Leshiy Mr-Leshiy marked this pull request as draft November 10, 2024 16:50
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review November 21, 2024 08:13
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Nov 21, 2024
apskhem
apskhem reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Just only one small change.

rust/cbork-cddl-parser/src/grammar/cddl_test.pest Outdated Show resolved Hide resolved
@Mr-Leshiy Mr-Leshiy requested a review from apskhem November 22, 2024 09:53
apskhem
apskhem reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 3910b60 into main Nov 26, 2024
24 checks passed
@minikin minikin deleted the feat/cddl-linter branch November 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apskhem apskhem apskhem left review comments

@minikin minikin minikin approved these changes

@stevenj stevenj Awaiting requested review from stevenj

@cong-or cong-or Awaiting requested review from cong-or

@saibatizoku saibatizoku Awaiting requested review from saibatizoku

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mr-Leshiy @minikin @apskhem