Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/rbac-registration): Introduce Cip0134UriSet type #119

Open
wants to merge 1 commit into
base: rbac-registration-improvements
Choose a base branch
from

Conversation

stanislav-tkach
Copy link
Contributor

@stanislav-tkach stanislav-tkach commented Dec 20, 2024

Description

  • The Cip0134UriSet type was added.
  • Option<Vec<_>> fields of the Cip509RbacMetadata structure were changed to Vec<_>.
  • Error handling becomes stricter.

Related Issue(s)

Closes #104.

Description of Changes

I have renamed Cip0134UriList to Cip0134UriSet because I don't think that "list" is a proper description for the current structure.

This pull request should be merged into the rbac-registration-improvements branch instead of main. The goal is to have separate smaller incremental changes that can be reviewed together in a separate pull request (from rbac-registration-improvements to main).

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach added the do not merge yet PR is not ready to merge yet label Dec 20, 2024
@stanislav-tkach stanislav-tkach self-assigned this Dec 20, 2024
@stanislav-tkach stanislav-tkach changed the title feat(rust/rbac-registration): Introduce Cip0134UriSet type feat(rust/rbac-registration): Introduce Cip0134UriSet type Dec 20, 2024
@stanislav-tkach stanislav-tkach force-pushed the cip0134set branch 2 times, most recently from d1251df to 5d20379 Compare December 25, 2024 14:51
@stanislav-tkach stanislav-tkach force-pushed the cip0134set branch 2 times, most recently from f6d1ec6 to a4366b2 Compare December 25, 2024 16:47
@stanislav-tkach stanislav-tkach marked this pull request as ready for review December 25, 2024 17:12
@stanislav-tkach stanislav-tkach added review me PR is ready for review and removed do not merge yet PR is not ready to merge yet labels Dec 25, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 229/229}$ | ${\color{red}Fail: 0/229}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant