Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add documentation for signed document metadata #116

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

saibatizoku
Copy link
Contributor

Description

Moves documentation for Signed Document Metadata from catalyst-voices.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added enhancement New feature or request review me PR is ready for review labels Dec 19, 2024
@saibatizoku saibatizoku requested a review from stevenj December 19, 2024 04:23
@saibatizoku saibatizoku self-assigned this Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@saibatizoku saibatizoku force-pushed the feat/add-signed-doc-metadata-to-arch-concepts-docs branch from 0c2faf8 to bba5db9 Compare December 19, 2024 15:52
@saibatizoku saibatizoku requested a review from dtscalac December 19, 2024 17:55
@saibatizoku saibatizoku enabled auto-merge (squash) December 19, 2024 17:56
@dtscalac
Copy link

@saibatizoku Looks good to me, the documentation is well explained and makes sense.

What do you think about adding a sample CBOR for an encoded document?

@saibatizoku
Copy link
Contributor Author

saibatizoku commented Dec 23, 2024

@saibatizoku Looks good to me, the documentation is well explained and makes sense.

What do you think about adding a sample CBOR for an encoded document?

@dtscalac sounds good to me. I've added an issue for this, so that we can define and build a properly documented example.

@saibatizoku saibatizoku merged commit 9851aac into main Dec 23, 2024
26 checks passed
@saibatizoku saibatizoku deleted the feat/add-signed-doc-metadata-to-arch-concepts-docs branch December 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants