Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/cardano-blockchain-types): add cardano-blockchain-types crate #107

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Dec 17, 2024

Description

Creates a new crate to hold self-contained Cardano blockchain types.
This allows us to break an emerging circular dependency with the RBAC crate logic.

Related Issue(s)

Arose from: input-output-hk/catalyst-voices#1366
#108

Breaking Changes

The types are based on types in cardano chain follower, but not 100% identical in order to make them more generalized.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj self-assigned this Dec 17, 2024
@stevenj stevenj added the review me PR is ready for review label Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Test Report | ${\color{lightgreen}Pass: 248/248}$ | ${\color{red}Fail: 0/248}$ |

@stevenj stevenj enabled auto-merge (squash) December 18, 2024 09:55
@stevenj stevenj requested a review from bkioshn December 18, 2024 09:55
bkioshn
bkioshn previously approved these changes Dec 18, 2024
@stevenj stevenj disabled auto-merge December 18, 2024 15:38
rust/cardano-blockchain-types/Cargo.toml Show resolved Hide resolved
rust/cardano-blockchain-types/src/hashes.rs Show resolved Hide resolved
rust/cardano-blockchain-types/src/hashes.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/fork.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
@stevenj stevenj enabled auto-merge (squash) December 19, 2024 12:48
@bkioshn bkioshn disabled auto-merge December 19, 2024 14:55
rust/cardano-blockchain-types/deps.tmp Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/multi_era_block_data.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/network.rs Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/point.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/txn_witness.rs Outdated Show resolved Hide resolved
@bkioshn bkioshn changed the title feat(rust): add cardano-blockchain-types crate feat(rust/cardano-blockchain-types): add cardano-blockchain-types crate Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants