-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string #102
Merged
stevenj
merged 3 commits into
main
from
fix-extraction-of-cardano-addresses-from-cardano-address-uri
Dec 13, 2024
Merged
fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string #102
stevenj
merged 3 commits into
main
from
fix-extraction-of-cardano-addresses-from-cardano-address-uri
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenj
requested changes
Dec 11, 2024
stanislav-tkach
changed the title
fix(rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string
fix(rust/rbac-registration): Fix extraction of Cardano Addresses from a cardano address URI string
Dec 11, 2024
stanislav-tkach
force-pushed
the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
2 times, most recently
from
December 11, 2024 13:18
f768c1e
to
48dbf9d
Compare
This was referenced Dec 11, 2024
stanislav-tkach
force-pushed
the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
from
December 11, 2024 18:43
48dbf9d
to
ca89c66
Compare
Test should pass after the input-output-hk/catalyst-ci#360 pull request is accepted. I will mark this pull request as "ready for review" after this is fixed. |
stanislav-tkach
force-pushed
the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
from
December 12, 2024 11:02
c5910fe
to
041b3c7
Compare
stanislav-tkach
force-pushed
the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
from
December 12, 2024 16:56
041b3c7
to
caceaa5
Compare
stanislav-tkach
added
review me
PR is ready for review
and removed
do not merge yet
PR is not ready to merge yet
labels
Dec 12, 2024
stanislav-tkach
force-pushed
the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
from
December 12, 2024 17:11
caceaa5
to
5537445
Compare
✅ Test Report | |
stevenj
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stevenj
deleted the
fix-extraction-of-cardano-addresses-from-cardano-address-uri
branch
December 13, 2024 10:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cip0134Uri
type has been added.extract_cip19_hash
was removed (Cip0134Uri::parse
can be used instead).Related Issue(s)
Closes #103.
Breaking Changes
extract_cip19_hash
function was removed.Please confirm the following checks