Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust/signed-doc): Add deserializer for Catalyst Signed Documents #101

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat(rust/signed-doc): Add deserializer for Catalyst Signed Documents #101

wants to merge 18 commits into from
+762 −111

Conversation

saibatizoku
Copy link
Contributor

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@saibatizoku saibatizoku added enhancement New feature or request do not merge yet PR is not ready to merge yet labels Dec 11, 2024
@saibatizoku saibatizoku linked an issue Dec 11, 2024 that may be closed by this pull request
🛠️ [TASK] : Make Signed documents library have a basic deserializer input-output-hk/catalyst-voices#1364
Open
3 tasks
@saibatizoku saibatizoku changed the title fix(rust/signed_doc): Replace ULID with UUIDv7 fix(rust/signed-doc): Replace ULID with UUIDv7 Dec 11, 2024
@saibatizoku saibatizoku force-pushed the fix/replace-ulid-with-uuidv7 branch 3 times, most recently from 1cd0243 to 96846f0 Compare December 16, 2024 03:03
@saibatizoku saibatizoku changed the title fix(rust/signed-doc): Replace ULID with UUIDv7 feat(rust/signed-doc): Add deserializer for Catalyst Signed Documents Dec 16, 2024
@saibatizoku saibatizoku force-pushed the fix/replace-ulid-with-uuidv7 branch from 8e07f3e to b0aa90a Compare December 17, 2024 15:11
@stevenj stevenj mentioned this pull request Dec 18, 2024
Merged
8 tasks
@saibatizoku
fix(rust/signed_doc): replace ULID with UUIDv7
a92c089
@saibatizoku
fix(rust/signed_doc): update meta.schema.json with definitions for uu…
8ee9c02 
…id v4 and v7
@saibatizoku
wip(rust/signed_doc): add basic structure for catalyst signed documen…
de6cb2c 
…t API

* refactor code from mk_signed_doc example into src/lib.rs
@saibatizoku
wip(rust/signed_doc): add API methods to get document metadata uuids
e12da32
@saibatizoku
fix(rust/signed_doc): fix README
9327287
@saibatizoku
wip(rust/signed_doc): Impl Display for CatalystSignedDocument, add in…
56ce553 
…spect example
@saibatizoku
wip(rust/signed_doc): print cose sign example
9014d36
@saibatizoku
feat(rust/signed-doc): add hex crate
c8e3d19
@saibatizoku
feat(rust/signed-doc): implement TryFrom<Vec<u8>> for CatalystSignedD…
e1e86e7 
…ocument

* updates cat-signed-doc example to display deserialized cose sign
  documents.
@saibatizoku
fix(rust/signed_doc): cleanup and fix to DocumentRef serde
33ab474
@saibatizoku
feat(rust/signed-doc): decode CoseSign from tagged or untagged bytes
b5b09a3
@saibatizoku
feat(rust/signed-doc): add subcommand to inspect cose sign from hex-e…
c41bbb5 
…ncoded strings
@saibatizoku
fix(rust/signed_doc): remove alg from top-level protected header
ea0bebd
@saibatizoku
feat(rust/signed-doc): refactor metadata into a module
d942e1e
@saibatizoku
feat(rust/signed-doc): add types for UUIDv4 and UUIDv7
875aa31
@saibatizoku
fix(rust/signed_doc): update code and examples with Uuid types
7e2425d
@saibatizoku
fix(rust/signed_doc): refactor Metadata impl TryFrom<coset::cbor::Value>
c28635d
@saibatizoku saibatizoku force-pushed the fix/replace-ulid-with-uuidv7 branch from 758afaf to c28635d Compare December 26, 2024 05:23
@saibatizoku
fix(rust/signed_doc): refactor impl TryFrom<&coset::cbor::Value> for …
8002c05 
…DocumentRef

* fix UuidV4 and UuidV7 is_valid methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saibatizoku saibatizoku

Labels
do not merge yet PR is not ready to merge yet enhancement New feature or request F14
Projects
Catalyst
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Make Signed documents library have a basic deserializer
1 participant
@saibatizoku