feat: Update sign tool v2 using new catalyst-voting crate | NPG-000
#718
+232
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
changed the title
sign tool v2 using new catalyst-voting cratesign tool v2 using new catalyst-voting crate
Mr-Leshiy
changed the title
sign tool v2 using new catalyst-voting cratesign tool v2 using new catalyst-voting crate
Mr-Leshiy
changed the title
sign tool v2 using new catalyst-voting cratesign tool v2 using new catalyst-voting crate | NPG-000
kukkok3
reviewed
Nov 4, 2024
Co-authored-by: Stefano Cunego <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
signtool with the new cli commandv2which generates theVoteCastjorm fragment using the newcatalyst-votingcrate https://github.com/input-output-hk/catalyst-libs/tree/main/rust/catalyst-voting.This PR updates the interface of the
signcli tool to have a few command options:sign v1 ...original jorm implementation.sign v2 ...using newcatalyst-votingcrate.The rest of the passing arguments remains the same
Closes #717