Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/cap nonce #702

Closed
wants to merge 2 commits into from
Closed

Test/cap nonce #702

wants to merge 2 commits into from

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Jun 19, 2024

Description

This is a PR for testing purposes which CAPS the Nonce of CIP-15/36 registration to the Slot# the transaction is found in.
This is an attempt to work around old Yoroi wallet registrations which eclipsing newer registrations because they used a very large nonce value.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It hasn't the PR is so that it a can be tested.

Test Configuration: if applicable

  • Generate a Snapshot with the Original Rules.
  • Generate a Snapshot with this test version.
  • Compare them and see if the difference introduces problems, or only fixes the Yoroi Nonce issue.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

kukkok3 and others added 2 commits June 14, 2024 11:46
@stevenj stevenj marked this pull request as draft June 19, 2024 05:44
@stevenj stevenj added bug Something isn't working enhancement New feature or request review me PR is ready for review labels Jun 19, 2024
@kukkok3
Copy link
Contributor

kukkok3 commented Jul 10, 2024

Testing done here input-output-hk/catalyst-voices#561

@kukkok3
Copy link
Contributor

kukkok3 commented Jul 10, 2024

@stevenj this LGTM if we want to merge it

@github-actions github-actions bot deleted the test/cap-nonce branch August 5, 2024 06:08
@stevenj stevenj marked this pull request as ready for review September 12, 2024 10:09
@stevenj stevenj closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants