Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set output_dir default value | NPG-000 #689

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

saibatizoku
Copy link
Contributor

Description

Adds a missing default value for a missing output_dir.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the bug Something isn't working label Mar 29, 2024
@saibatizoku saibatizoku requested a review from jmgilman March 29, 2024 14:30
@saibatizoku saibatizoku self-assigned this Mar 29, 2024
@jmgilman jmgilman changed the title fix: Set output_dir default value fix: Set output_dir default value | NPG-000 Mar 29, 2024
@jmgilman jmgilman merged commit 543779c into main Mar 29, 2024
59 of 61 checks passed
@jmgilman jmgilman deleted the fix/ideascale-importer-args branch March 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants