Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (yay or nay): add choice to current jorm crypto config feat | NPG-000 #652

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

cong-or
Copy link
Contributor

@cong-or cong-or commented Jan 8, 2024

add choice flag to vote signer, tied to current jorm config where 0 is NO and 1 is YES in the context of position in array.

@cong-or cong-or requested a review from kukkok3 January 8, 2024 11:33
@cong-or cong-or changed the title feat(yay or nay): add choice to current jorm crypto config feat: (yay or nay): add choice to current jorm crypto config feat | NPG-000 Jan 8, 2024
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) January 8, 2024 11:40
@kukkok3 kukkok3 merged commit 024bb07 into main Jan 8, 2024
58 of 60 checks passed
@kukkok3 kukkok3 deleted the feat/vote-signer-choice branch January 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants