Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbsync snapshot): Remove GVC and DRep functionality from importer | NPG-000 #648

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

saibatizoku
Copy link
Contributor

Description

Removes GVC integration and DRep functionality from the DBSync snapshot importer.

This removes DRep-related command-line arguments.

Closes #646

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the enhancement New feature or request label Dec 18, 2023
@saibatizoku saibatizoku added this to the F11-Launch milestone Dec 18, 2023
@saibatizoku saibatizoku requested a review from jmgilman December 18, 2023 16:29
@saibatizoku saibatizoku self-assigned this Dec 18, 2023
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmgilman jmgilman merged commit c72da5a into main Dec 18, 2023
59 of 60 checks passed
@jmgilman jmgilman deleted the feature/remove-gvc-and-dreps-from-importer branch December 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow disabling GVC
2 participants