Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add eligible voters snapshot metric | NPG-0000 #581

Merged
merged 3 commits into from
Sep 29, 2023
Merged

chore: Add eligible voters snapshot metric | NPG-0000 #581

merged 3 commits into from
Sep 29, 2023

Conversation

FelipeRosa
Copy link
Contributor

@FelipeRosa FelipeRosa commented Sep 27, 2023 •
edited
Loading

Description

This PR adds "eligible voters" metric to the snapshot importer logs as being the amount of wallets able to vote.

How Has This Been Tested?

Executed the voting node + snapshot importer locally.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FelipeRosa FelipeRosa self-assigned this Sep 27, 2023
@FelipeRosa FelipeRosa changed the title add eligible voters snapshot metric chore: Add eligible voters snapshot metric | NPG-0000 Sep 27, 2023
@FelipeRosa FelipeRosa force-pushed the add-eligible-voters-snapshot-metric branch from 79e2d50 to 3222a9e Compare September 27, 2023 13:06
@FelipeRosa FelipeRosa added the review me PR is ready for review label Sep 27, 2023
@FelipeRosa FelipeRosa enabled auto-merge (squash) September 27, 2023 14:20
Mr-Leshiy
Mr-Leshiy approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kukkok3
kukkok3 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelipeRosa FelipeRosa merged commit d0f748a into main Sep 29, 2023
@FelipeRosa FelipeRosa deleted the add-eligible-voters-snapshot-metric branch September 29, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@FelipeRosa FelipeRosa

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelipeRosa @Mr-Leshiy @kukkok3