Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cordova publshing | NPG-8179 #572

Merged
merged 14 commits into from
Sep 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/cordova_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
upload_url: ${{ steps.create_release.outputs.upload_url }}
version: ${{ steps.get_version.outputs.version }}
version: ${{ steps.create_release.outputs.id }}
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -30,10 +30,6 @@ jobs:
draft: true
prerelease: false

- name: Set version output
id: get_version
run: echo ::set-output name=version::``${GITHUB_REF#refs/tags/}``

build_uniffi:
name: Build uniffi jni shared libs for android with cross
runs-on: ubuntu-latest
Expand All @@ -44,7 +40,6 @@ jobs:
- { target: armv7-linux-androideabi }
- { target: i686-linux-android }
- { target: x86_64-linux-android }

steps:
- name: Checkout code
uses: actions/checkout@v1
Expand Down Expand Up @@ -113,7 +108,7 @@ jobs:

package_cordova_plugin:
runs-on: ubuntu-latest
needs: [build_uniffi, build_lipo_asset]
needs: [initial_release, build_uniffi, build_lipo_asset]

steps:
- name: Checkout code
Expand Down Expand Up @@ -176,16 +171,16 @@ jobs:

- name: rename-tarball
run: |
find . \
-name wallet-cordova-plugin*.tgz \
-exec mv {} chain-wallet-libs-${{ needs.initial_release.outputs.version }}-cordova.tgz \;
find ./src/chain-wallet-libs -name wallet-cordova-plugin*.tgz -exec mv {} {} \;
mv wallet-cordova-plugin*.tgz wallet-cordova-plugin-${{ needs.initial_release.outputs.version }}.tgz
ls

- name: Upload binaries to release
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ needs.initial_release.outputs.upload_url }}
asset_path: ./chain-wallet-libs-${{ needs.initial_release.outputs.version }}-cordova.tgz
asset_name: chain-wallet-libs-cordova-${{ needs.initial_release.outputs.version }}
asset_path: ./wallet-cordova-plugin-${{ needs.initial_release.outputs.version }}.tgz
asset_name: wallet-cordova-plugin-${{ needs.initial_release.outputs.version }}.tgz
asset_content_type: application/gzip
Loading