feat: Add `registration/voter` endpoint to poem service | NPG-8137 #559

Mr-Leshiy · 2023-09-12T15:00:49Z

Description

Added registration/voter endpoint implementation for poem service
Made small refactoring

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

voter_test

stevenj

Hi,
So there a few things here because I want to make sure we are on a solid footing before we add too much code to the code base.

src/cat-data-service/src/poem_types/event.rs

src/cat-data-service/src/poem_types/registration.rs

src/cat-data-service/src/types/mod.rs

src/cat-data-service/src/service/poem_service.rs

src/cat-data-service/src/service/api/registration/mod.rs

src/cat-data-service/src/poem_types/registration.rs

src/cat-data-service/src/service/api/health/mod.rs

stevenj

See suggested changes.

src/cat-data-service/src/service/api/registration/mod.rs

src/cat-data-service/src/service/common/objects/stake_public_key.rs

src/cat-data-service/src/service/docs/mod.rs

src/cat-data-service/src/service/poem_service.rs

src/cat-data-service/src/state/jorm_mock.rs

src/cat-data-service/src/state/mod.rs

Co-authored-by: Steven Johnson <[email protected]>

…ey.rs Co-authored-by: Steven Johnson <[email protected]>

Co-authored-by: Steven Johnson <[email protected]>

…ess.rs Co-authored-by: Steven Johnson <[email protected]>

Co-authored-by: Steven Johnson <[email protected]>

…ey.rs Co-authored-by: Steven Johnson <[email protected]>

Co-authored-by: Steven Johnson <[email protected]>

Mr-Leshiy added 6 commits September 12, 2023 11:13

add health tests

8b8b275

refactor

d20c45a

add get_voter endpoint

27e596a

update

98fa4e0

fix

ba891e3

add tests

d4ba8cb

Mr-Leshiy requested review from stevenj, FelipeRosa, cong-or, minikin and saibatizoku and removed request for FelipeRosa September 12, 2023 15:01

Mr-Leshiy self-assigned this Sep 12, 2023

Mr-Leshiy added the review me PR is ready for review label Sep 12, 2023

Mr-Leshiy changed the title ~~feat: Add registration/voter endpoint to poem service | NPG-8137~~ feat: Add registration/voter endpoint to poem service | NPG-8137 Sep 12, 2023

fix clippy

7ecff29

Mr-Leshiy mentioned this pull request Sep 13, 2023

feat: Add registration/delegations endpoint to poem | NPG-8137 #560

Closed

5 tasks

stevenj requested changes Sep 13, 2023

View reviewed changes

return back Responses sections

d3147f9

stevenj mentioned this pull request Sep 14, 2023

feat: Add poem openapi Objective types implementation | NPG-8147 #561

Closed

4 tasks

stevenj added the do not merge yet PR is not ready to be merged yet label Sep 14, 2023

Mr-Leshiy added 6 commits September 14, 2023 23:33

update

6499a49

update

ed2939d

fix visibility

b42867c

fix

bced403

update

6a8f3f4

move axum types under the legacy_service module

aed00f9

Mr-Leshiy requested a review from stevenj September 18, 2023 08:42

stevenj requested changes Sep 19, 2023

View reviewed changes

Mr-Leshiy and others added 20 commits September 19, 2023 10:12

Update src/cat-data-service/src/service/api/registration/mod.rs

4bfb3a0

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/stake_public_k…

91eb0d8

…ey.rs Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/api/registration/mod.rs

66aea47

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/api/registration/mod.rs

2c26280

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/api/registration/mod.rs

bf7fa31

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/api/registration/mod.rs

40a25f1

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/docs/mod.rs

c00fbe9

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/state/mod.rs

ebb9702

Co-authored-by: Steven Johnson <[email protected]>

add jorm_mock docs

4dd6e6a

Update src/cat-data-service/src/service/poem_service.rs

8161ea4

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/delegator_addr…

1f27b80

…ess.rs Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/delegator_addr…

1423ea9

…ess.rs Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/event_id.rs

2ea7f3f

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/stake_public_k…

e7152b6

…ey.rs Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/voter.rs

621d32c

Co-authored-by: Steven Johnson <[email protected]>

fix

55dbdcc

Update src/cat-data-service/src/service/common/objects/voter_group_id.rs

bd103f0

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/voter_info.rs

562413a

Co-authored-by: Steven Johnson <[email protected]>

Update src/cat-data-service/src/service/common/objects/voting_key.rs

e9ff201

Co-authored-by: Steven Johnson <[email protected]>

fix

731340a

Mr-Leshiy requested a review from stevenj September 19, 2023 07:41

fix visibility

be11f69

stevenj approved these changes Sep 19, 2023

View reviewed changes

stevenj merged commit 77185a1 into feature/poem-migration-start Sep 19, 2023
21 checks passed

stevenj deleted the feature/poem-registration branch September 19, 2023 08:43

Mr-Leshiy removed the do not merge yet PR is not ready to be merged yet label Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add `registration/voter` endpoint to poem service | NPG-8137 #559

feat: Add `registration/voter` endpoint to poem service | NPG-8137 #559

Mr-Leshiy commented Sep 12, 2023 •

edited

Loading

stevenj left a comment

stevenj left a comment

feat: Add registration/voter endpoint to poem service | NPG-8137 #559

feat: Add registration/voter endpoint to poem service | NPG-8137 #559

Conversation

Mr-Leshiy commented Sep 12, 2023 • edited Loading

Description

Type of change

How Has This Been Tested?

stevenj left a comment

Choose a reason for hiding this comment

stevenj left a comment

Choose a reason for hiding this comment

feat: Add `registration/voter` endpoint to poem service | NPG-8137 #559

feat: Add `registration/voter` endpoint to poem service | NPG-8137 #559

Mr-Leshiy commented Sep 12, 2023 •

edited

Loading