-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Earthly integration tests use 'earthly/dind' container | NPG-000 #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm assuming this fixed the issue locally?
Holding this PR until the tests are configured to run using Earthly satellites. |
26ac913
to
451b04f
Compare
This is actually good to go. The tests are running correctly in CI using the Earthly Satellite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
CI tests are breaking because Earthly tries to install docker in containers that don't have it, causing unexpected timeouts. As recommended by Earthly Docs, https://docs.earthly.dev/best-practices#use-earthly-dind , this PR updates integration tests to address this problem.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
earthly -P +test
Checklist