Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Earthly integration tests use 'earthly/dind' container | NPG-000 #537

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

saibatizoku
Copy link
Contributor

Description

CI tests are breaking because Earthly tries to install docker in containers that don't have it, causing unexpected timeouts. As recommended by Earthly Docs, https://docs.earthly.dev/best-practices#use-earthly-dind , this PR updates integration tests to address this problem.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Local execution of earthly -P +test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the review me PR is ready for review label Aug 25, 2023
@saibatizoku saibatizoku requested review from jmgilman and a team August 25, 2023 18:02
@saibatizoku saibatizoku self-assigned this Aug 25, 2023
@saibatizoku saibatizoku enabled auto-merge (squash) August 25, 2023 18:02
@saibatizoku saibatizoku changed the title fix: Earthly integration tests use 'earthly/dind' container fix: Earthly integration tests use 'earthly/dind' container | NPG-000 Aug 25, 2023
jmgilman
jmgilman previously approved these changes Aug 25, 2023
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming this fixed the issue locally?

@saibatizoku saibatizoku disabled auto-merge August 25, 2023 19:04
@saibatizoku saibatizoku added the do not merge yet PR is not ready to be merged yet label Aug 25, 2023
@saibatizoku
Copy link
Contributor Author

Holding this PR until the tests are configured to run using Earthly satellites.

@saibatizoku
Copy link
Contributor Author

This is actually good to go. The tests are running correctly in CI using the Earthly Satellite.

@saibatizoku saibatizoku removed the do not merge yet PR is not ready to be merged yet label Sep 26, 2023
@minikin minikin enabled auto-merge (squash) September 26, 2023 09:33
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit 2a68afe into main Sep 27, 2023
27 checks passed
@minikin minikin deleted the fix-earthly-integration-testing branch September 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants