fix: retrieve events always in UTC #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #168 |
Closed
When creating an event, the timestamp's timezone was silently dropped and replaced with the timezone of the local system. Timestamps returned by outlook are in UTC, such that syncing from outlook to outlook resulted in shifted events on non-UTC systems. Explicitly convert timestamps to UTC to ensure correctness.
MichaelEischer
force-pushed
the
fix-168
branch
from
01a0f10
to
5f6ae85
Compare
MichaelEischer
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure we're retrieving events in UTC and write them in the local timezone of the user.