Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smooth scroll to index on SSR hydration #591

Merged
merged 6 commits into from
Jan 1, 2025

Conversation

aggarwal-h
Copy link
Contributor

@aggarwal-h aggarwal-h commented Dec 22, 2024

Here are the before and after results for this PR:

Before After
https://github.com/user-attachments/assets/1f9007b2-24f6-4fad-9051-0aa920d0ee81 https://github.com/user-attachments/assets/f645f858-113f-43dc-b281-a43b0612fc8e

I have updated the SSR story in the storybook to include this example. It has been added as a selectable checkbox.

Closes #590.

@aggarwal-h aggarwal-h marked this pull request as draft December 23, 2024 01:48
@aggarwal-h
Copy link
Contributor Author

Moving this PR to draft while I address test failures.

@aggarwal-h aggarwal-h marked this pull request as ready for review December 24, 2024 01:47
Copy link
Owner

@inokawa inokawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inokawa inokawa merged commit 821400e into inokawa:main Jan 1, 2025
5 checks passed
@inokawa
Copy link
Owner

inokawa commented Jan 1, 2025

Released in 0.39.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Smooth scroll to index does not work properly on mount when ssrCount is set
2 participants