Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX LDAP config: il filtro cn=%s non è adatto allo schema RFC2307 #8

Merged
merged 1 commit into from
May 20, 2024
Merged

FIX LDAP config: il filtro cn=%s non è adatto allo schema RFC2307 #8

merged 1 commit into from
May 20, 2024

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented May 14, 2024

No description provided.

@eLBati
Copy link
Member Author

eLBati commented May 15, 2024

Ciao @DavidePrincipi you are proposing this change, right?

I tried it on our NethServer VM and trying to login with LDAP credentials it fails with the following log

2024-05-14T18:09:16+02:00 [1:odoo112:odoo-app] 2024-05-14 16:09:16,899 6 INFO odoo odoo.addons.base.models.res_users: Login failed for db:odoo login:testldap from 192.168.199.51
2024-05-14T18:09:16+02:00 [1:ldapproxy1:ldapproxy] 2024/05/14 16:09:16 [info] 28#28: *131 client 127.0.0.1:40562 connected to 127.0.0.1:20002
2024-05-14T18:09:16+02:00 [1:ldapproxy1:ldapproxy] 2024/05/14 16:09:16 [info] 28#28: *131 proxy 192.168.19.118:38914 connected to 192.168.19.118:636
2024-05-14T18:09:16+02:00 [1:samba2:samba-dc] Auth: [LDAP,simple bind/TLS] user [NS8LBI]\[[[email protected]]](https://[email protected]]) at [Tue, 14 May 2024 16:09:16.912978 UTC] with [Plaintext] status [NT_STATUS_OK] workstation [DC2] remote host [ipv4:192.168.19.118:38914] became [NS8LBI]\[ldapservice] [S-1-5-21-1939888212-912496496-251616702-1103]. local host [ipv4:192.168.19.118:636]
2024-05-14T18:09:16+02:00 [1:ldapproxy1:ldapproxy] 2024/05/14 16:09:16 [info] 28#28: *131 client disconnected, bytes from/to client:147/252, bytes from/to upstream:252/147

What do you suggest?

Thanks!

cc @nardellu

DavidePrincipi
DavidePrincipi reviewed May 15, 2024
View reviewed changes
imageroot/actions/configure-module/90ldap Outdated
@@ -20,7 +20,7 @@ ldap_base = "{ldap_base}"

# Filtro utilizzato per cercare gli account degli utenti nel database LDAP.
# È un filtro LDAP arbitrario nella rappresentazione delle stringhe.
ldap_filter = "cn=%s"
ldap_filter = "uid=%s"
Copy link

@DavidePrincipi DavidePrincipi May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for schema RFC2307 (OpenLDAP), however with AD the attribute is saMAccountName.

For example, look at https://github.com/NethServer/ns8-nextcloud/blob/e91966aba0c92e701727098e004ea912f5082bc1/imageroot/bin/setup-ldap#L91

Nice to add: https://nethserver.github.io/ns8-core/core/user_domains/#hidden-users-and-groups

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidePrincipi changed, thanks!

@nardellu nardellu merged commit 3feb4e2 into master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidePrincipi DavidePrincipi DavidePrincipi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eLBati @DavidePrincipi @nardellu