Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trust probe status code #66

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix trust probe status code #66

merged 1 commit into from
Oct 1, 2024

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Sep 30, 2024

Description

  • Fix trust probe not setting a response status code in certain failure scenarios.
  • Add HandlerOpts.Dev, which controls whether the SDK is in "dev mode" (taking precedence over INNGEST_DEV). This is necessary for testing, since env vars bleed between tests.
  • Fix introspection not responding with the correct data when in "dev mode" and an invalid signature is sent.

@amh4r amh4r requested a review from tonyhb September 30, 2024 23:18
@amh4r amh4r merged commit e9fbcce into main Oct 1, 2024
7 checks passed
@amh4r amh4r deleted the fix-trust-probe-status-code branch October 1, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants