Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-band sync capability #56

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add in-band sync capability #56

merged 3 commits into from
Sep 12, 2024

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Sep 12, 2024

Description

Add the "in-band sync" capability. This capability is inactive unless the user explicitly allows it via a new INNGEST_ALLOW_IN_BAND_SYNC env var.

Maintainers: To read more about in-band syncing, refer to our internal spec here.

Changes

  • Update register function to conditionally perform an in-band or out-of-band sync.
    • inBandSync is a new function that contains our in-band sync logic.
    • outOfBandSync contains the same logic that register used to have, but function config building is extracted to createFunctionConfigs.
  • Add INNGEST_ALLOW_IN_BAND_SYNC env var to control whether in-band syncing is allowed. It defaults to false for now, but will default to true when in-band syncing is stable.
  • Update OSS to 4c207d8fb0ce.

@amh4r amh4r merged commit 93d743e into main Sep 12, 2024
6 checks passed
@amh4r amh4r deleted the in-band-sync branch September 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants