Fix: double slash in GET transactions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
reviewed
Oct 3, 2024
| @@ -42,7 +42,7 @@ impl TxPoller { | |||
| /// unique transactions that haven't been seen before are sent into the builder pipeline. | |||
| pub async fn check_tx_pool(&mut self) -> Result<Vec<TxEnvelope>, Error> { | |||
| let mut unique: Vec<TxEnvelope> = Vec::new(); | |||
| let result = self.client.get(self.config.tx_pool_url.to_string() + "/get").send().await?; | |||
| let result = self.client.get(self.config.tx_pool_url.to_string() + "get").send().await?; | |||
There was a problem hiding this comment.
Was this actually causing an issue with the slash?
There was a problem hiding this comment.
this was what was causing the originally observed bug, yes
Evalir
approved these changes
Oct 3, 2024
anna-carroll
force-pushed
the
anna/debug-parsing
branch
from
0e25cdc to
d52e3b0
Compare
Evalir
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.