feat: oauth for builder [ENG-493] #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rswanson
force-pushed
the
swanny/feat_oauth_for_builder
branch
2 times, most recently
from
d8f31ad to
2c6e1d6
Compare
| let resp: reqwest::Response = self | ||
| .client | ||
| .post(self.config.quincey_url.as_ref()) | ||
| .json(sig_request) | ||
| .bearer_auth(token.access_token().secret()) |
There was a problem hiding this comment.
should we also address tx pool oath in the same PR?
we don't necessarily need to worry about efficiency of streamlining to one oath call for both tx pool & quincey within the example builder but would be a nice-to-have if it were simple
There was a problem hiding this comment.
currently we don't call the protected endpoints (/get-order(s)) so there isn't anything to update. Adding the functionality itself would be outside the scope of this
rswanson
force-pushed
the
swanny/feat_oauth_for_builder
branch
2 times, most recently
from
d257ea1 to
7265e3a
Compare
prestwich
reviewed
Sep 20, 2024
rswanson
force-pushed
the
swanny/feat_oauth_for_builder
branch
from
7265e3a to
a267157
Compare
prestwich
approved these changes
Sep 20, 2024
rswanson
force-pushed
the
swanny/feat_oauth_for_builder
branch
from
a267157 to
b3147ac
Compare
rswanson
force-pushed
the
swanny/feat_oauth_for_builder
branch
from
b3147ac to
8e68614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added OAuth2 authentication for the builder's communication with Quincey.
What changed?
How to test?
Why make this change?
This change enhances the security of the communication between the builder and Quincey by implementing OAuth2 authentication. It ensures that only authorized builders can interact with Quincey, improving the overall security posture of the system.