Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crate): disable std for all deps #61

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Oct 23, 2024

This fixes an issue with the no-std PR, which did not properly disable std for all the other deps.

Also feature gates a few alloy features under std.

This fixes an issue with the no-std PR, which did not properly disable std for all the other deps. This is blocked on revm/alloy implementing `core::error::Error` instead of `std` on the erroring types.
Copy link
Member Author

Evalir commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Evalir and the rest of your teammates on Graphite Graphite

@prestwich
Copy link
Contributor

you'll need to feature-gate pub mod journal behind std

@Evalir Evalir requested a review from prestwich October 23, 2024 14:48
@Evalir Evalir marked this pull request as ready for review October 23, 2024 14:48
@prestwich prestwich merged commit 5f8a86e into main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants